[VL] tools/workload/tpch: Close sql files to avoid resources leak#10785
Merged
jinchengchenghh merged 2 commits intoapache:mainfrom Oct 12, 2025
Merged
[VL] tools/workload/tpch: Close sql files to avoid resources leak#10785jinchengchenghh merged 2 commits intoapache:mainfrom
jinchengchenghh merged 2 commits intoapache:mainfrom
Conversation
zhztheplayer
changed the title
| println(fileContents) | ||
| time{spark.sql(fileContents).collectAsList()} | ||
| //spark.sql(fileContents).explain | ||
| val fileContents = { |
Contributor
There was a problem hiding this comment.
Please don't change the function time, just close the file
Contributor
Author
There was a problem hiding this comment.
Done. I mean to print the final results for statistics without any middle results. Maybe the middle results is important for other situations.
xinghuayu007
force-pushed
the
my/optimize_tpch
branch
from
2ada0fb to
c4b9967
Compare
jinchengchenghh
approved these changes
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
SQL files is not close after running, which maybe cause resources leak.
This patch also prints the results in lines for statistics convenience.
How was this patch tested?